Question

Online shopping cart (continued) (Java)

Hello, I need help with Java to figure this out. In my Shopping Cart Manager Class (Bottom Code), I get "Resource leak: 'sc' is never closed." I have tried multiple things and cannot figure it out. Thank you.

Online shopping cart (continued) (Java)

Hello, I need help with Java to figure this out. In my Shopping Cart Manager Class (Bottom Code), I get "Resource leak: 'sc' is never closed." I have tried multiple things and cannot figure it out. Thank you.

/*Shopping Cart Manager Class*/

import java.util.Scanner;

public class ShoppingCartManager {
   public static void main(String[] args) {
       String customerName, currentDate;
       Scanner sc = new Scanner(System.in);
       System.out.print("Enter Customer's Name:");
       customerName = sc.nextLine().toString().trim();
       System.out.println();
       System.out.print("Enter Today's Date:");
       currentDate = sc.nextLine().toString().trim();
       System.out.println();
       ShoppingCart cart = new ShoppingCart(customerName, currentDate);
       System.out.println("Customer Name:" + cart.getCustomerName());
       System.out.println("Today's Date:" + cart.getDate());
       printMenu(cart);

   }
   /* Prints the menu, and builds the shopping cart * object passed in as parameter */
      private static void printMenu(ShoppingCart cart) {
       Scanner sc = new Scanner(System.in);
       char choice = 'z';
       System.out.println("MENU:");
       System.out.println("a - Add Item To Cart");
       System.out.println("d - Remove Item from Cart");
       System.out.println("c - Change Item Quantity");
       System.out.println("i - Output Items' Description");
       System.out.println("o - Output Shopping Cart");
       System.out.println("q - Quit");
       System.out.print("Enter an option:");
       choice = sc.nextLine().trim().charAt(0);
       while (choice != 'q') {
           if (choice != 'a' && choice != 'd' && choice != 'c' && choice != 'i' && choice != 'o') {
               // An invalid choice is made
               // Prompt for choice again
               System.out.print("Enter an option:");
               choice = sc.nextLine().trim().charAt(0);
               continue;
           } else {
               switch (choice) {
               case 'o': {
                   System.out.println("OUTPUT SHOPPING CART");
                   cart.printTotal();
                   break;
               }
               case 'i': {
                   System.out.println("OUTPUT ITEMS' DESCRIPTIONS");
                   cart.printDescriptions();
                   break;
               }
               case 'a': {
                   String name, desc;
                   int price, qty;
                   System.out.println("ADD ITEM TO CART");
                   System.out.println("Enter Item name:");
                   name = sc.nextLine().trim().toString();
                   System.out.println("Enter Item description:");
                   desc = sc.nextLine().trim().toString();
                   System.out.println("Enter Item price:");
                   price = sc.nextInt();
                   sc.nextLine();
                   System.out.println("Enter Item quantity:");
                   qty = sc.nextInt();
                   sc.nextLine();
                   ItemToPurchase itemToPurchase = new ItemToPurchase(name, desc, qty, price);
                   cart.addItem(itemToPurchase);
                   break;
               }
               case 'd': {
                   String itemToRemove;
                   System.out.println("REMOVE ITEM FROM CART");
                   System.out.println("Enter name of item to remove:");
                   itemToRemove = sc.nextLine().trim().toString();
                   cart.removeItem(itemToRemove);
                   break;
               }
               case 'c': {
                   String itemName;
                   int itemQty;
                   System.out.println("CHANGE ITEM QUANTITY");
                   System.out.println("Enter item name:");
                   itemName = sc.nextLine().trim().toString();
                   System.out.println("Enter the new quantity:");
                   itemQty = sc.nextInt();
                   sc.nextLine();
                   ItemToPurchase item = new ItemToPurchase(itemName, "none", itemQty, 0);
                   cart.modifyItem(item);
                   break;
               }
               }
               System.out.print("Enter an option:");
               choice = sc.nextLine().trim().charAt(0);
           }
       }
   }
}

Answer 1

Note:

###########

The problem which you have given in the question arrised because you have not closed Scanner object sc in the code.

To do that just use sc.close(); at the end of each method which uses scanner. I cant run the code as the supporting classes like ShoppingCart are missing in the question you have given. Try adding sc.close() at the end of functions which uses sc as below

//########################## PGM START ##################################

package one;

import java.util.Scanner;

public class ShoppingCartManager {
   public static void main(String[] args) {
       String customerName, currentDate;
       Scanner sc = new Scanner(System.in);
       System.out.print("Enter Customer's Name:");
       customerName = sc.nextLine().toString().trim();
       System.out.println();
       System.out.print("Enter Today's Date:");
       currentDate = sc.nextLine().toString().trim();
       System.out.println();
       ShoppingCart cart = new ShoppingCart(customerName, currentDate);
       System.out.println("Customer Name:" + cart.getCustomerName());
       System.out.println("Today's Date:" + cart.getDate());
       printMenu(cart);
       sc.close();

   }
   /* Prints the menu, and builds the shopping cart * object passed in as parameter */
      private static void printMenu(ShoppingCart cart) {
       Scanner sc = new Scanner(System.in);
       char choice = 'z';
       System.out.println("MENU:");
       System.out.println("a - Add Item To Cart");
       System.out.println("d - Remove Item from Cart");
       System.out.println("c - Change Item Quantity");
       System.out.println("i - Output Items' Description");
       System.out.println("o - Output Shopping Cart");
       System.out.println("q - Quit");
       System.out.print("Enter an option:");
       choice = sc.nextLine().trim().charAt(0);
       while (choice != 'q') {
           if (choice != 'a' && choice != 'd' && choice != 'c' && choice != 'i' && choice != 'o') {
               // An invalid choice is made
               // Prompt for choice again
               System.out.print("Enter an option:");
               choice = sc.nextLine().trim().charAt(0);
               continue;
           } else {
               switch (choice) {
               case 'o': {
                   System.out.println("OUTPUT SHOPPING CART");
                   cart.printTotal();
                   break;
               }
               case 'i': {
                   System.out.println("OUTPUT ITEMS' DESCRIPTIONS");
                   cart.printDescriptions();
                   break;
               }
               case 'a': {
                   String name, desc;
                   int price, qty;
                   System.out.println("ADD ITEM TO CART");
                   System.out.println("Enter Item name:");
                   name = sc.nextLine().trim().toString();
                   System.out.println("Enter Item description:");
                   desc = sc.nextLine().trim().toString();
                   System.out.println("Enter Item price:");
                   price = sc.nextInt();
                   sc.nextLine();
                   System.out.println("Enter Item quantity:");
                   qty = sc.nextInt();
                   sc.nextLine();
                   ItemToPurchase itemToPurchase = new ItemToPurchase(name, desc, qty, price);
                   cart.addItem(itemToPurchase);
                   break;
               }
               case 'd': {
                   String itemToRemove;
                   System.out.println("REMOVE ITEM FROM CART");
                   System.out.println("Enter name of item to remove:");
                   itemToRemove = sc.nextLine().trim().toString();
                   cart.removeItem(itemToRemove);
                   break;
               }
               case 'c': {
                   String itemName;
                   int itemQty;
                   System.out.println("CHANGE ITEM QUANTITY");
                   System.out.println("Enter item name:");
                   itemName = sc.nextLine().trim().toString();
                   System.out.println("Enter the new quantity:");
                   itemQty = sc.nextInt();
                   sc.nextLine();
                   ItemToPurchase item = new ItemToPurchase(itemName, "none", itemQty, 0);
                   cart.modifyItem(item);
                   break;
               }
               }
               System.out.print("Enter an option:");
               choice = sc.nextLine().trim().charAt(0);
           }
       }
       sc.close();
   }
}

//#################################### PGM END #############################