Question

I need some with this program, please look at the changes I need closely. Its running correctly, but I need to do a few adjustments here is the list of changes I need:

1. All of the integers on a single line, sorted in ascending order.

2. The median value of the sorted array on a single line

3. The average of the sorted array on a single line

Here is the program:

#include<stdio.h>
#include<stdlib.h>
/* This places the Adds Value to the sorted array */
void Add( int arr[], int Value, int Size){
int i;
for(i=0;i<Size;i++)
arr[i]+=Value;

}
/* This places the Remove Value to the sorted array */
void Remove( int arr[], int Value, int Size) {
int i;
for(i=0;i<Size;i++)
arr[i]-=Value;
}
/* Returns the size of the array in BYTES */
long Size( int arr[]) {
return sizeof(arr);
}
/* Returns non-zero if Value is contained in array, 0 if Value is not contained in the array, the size parameter is the number of elements currently in the array)*/
int Contains( int arr[], int Value, int Size ) {
int i;
for(i=0;i<Size;i++)
if(arr[i]==Value)
return 1;
return 0;
}
int main(){
FILE *fp;
fp=fopen("numbers.txt","r");
int t;
int a[100],lastIndex=0,i,j=0;
float sum=0;
while( fscanf(fp,"%d",&t)!=EOF )
{
/* printf("\nThe Element is t=%d\n",t); */
sum+=t;
if(lastIndex==0)
a[lastIndex]=t;
else if(a[lastIndex]<=t){
a[lastIndex]=t;
}
else{
for(i=lastIndex;i>0;i--){
if(a[i]>=t)
a[i+1]=a[i];
else {
  
break;
}
}
a[i+1]=t;
}
for(i=0;i<=lastIndex;i++)
printf("%d\t",a[i]);

lastIndex++;
}

printf("\nThe Sorted array is :");
for(i=0;i<lastIndex;i++)
printf("%d\t",a[i]);
float median;
if(lastIndex%2!=0)
median=a[lastIndex/2];
else
median=(a[lastIndex/2]+a[lastIndex/2-1])/2.0;
printf("\nThe median of the sorted array: %.2f",median);
printf("\nThe average of the sorted array: %.2f",sum/lastIndex);
return 0;
}

Answer 1

I have correcetd your code You were having mistake in sorting part I am listing down your mistakes here and also commented in code where i have change the code .

1.In else part you were checking a[lastIndex]<=t but it should be :

  else if (a[lastIndex - 1] <= t) //here we will check at lastIndex -1 for less then condition with t
        {
            a[lastIndex] = t;
        }

2.In for loop part ,loop will range from LastIndex-1 to 0:

else
        {
            for (i = lastIndex - 1; i >= 0; i--) //here Range should be from index-1 to i>=0
            {
                if (a[i] >= t)
                    a[i + 1] = a[i];
                else
                {

                    break;
                }
            }
            a[i + 1] = t;
        }

Here I writing the corrected code :

#include <stdio.h>
#include <stdlib.h>
/* This places the Adds Value to the sorted array */
void Add(int arr[], int Value, int Size)
{
    int i;
    for (i = 0; i < Size; i++)
        arr[i] += Value;
}
/* This places the Remove Value to the sorted array */
void Remove(int arr[], int Value, int Size)
{
    int i;
    for (i = 0; i < Size; i++)
        arr[i] -= Value;
}
/* Returns the size of the array in BYTES */
long Size(int arr[])
{
    return sizeof(arr);
}
/* Returns non-zero if Value is contained in array, 0 if Value is not contained in the array, the size parameter is the number of elements currently in the array)*/
int Contains(int arr[], int Value, int Size)
{
    int i;
    for (i = 0; i < Size; i++)
        if (arr[i] == Value)
            return 1;
    return 0;
}
int main()
{
    FILE *fp;
    fp = fopen("numbers.txt", "r");
    int t;
    int a[100], lastIndex = 0, i, j = 0;
    float sum = 0;
    while (fscanf(fp, "%d", &t) != EOF)
    {
        /* printf("\nThe Element is t=%d\n",t); */
        sum += t;
        if (lastIndex == 0)
            a[lastIndex] = t;
        else if (a[lastIndex - 1] <= t) //here we will check at lastIndex -1 for less then condition with t
        {
            a[lastIndex] = t;
        }
        else
        {
            for (i = lastIndex - 1; i >= 0; i--) //here Range should be from index-1 to i>=0
            {
                if (a[i] >= t)
                    a[i + 1] = a[i];
                else
                {

                    break;
                }
            }
            a[i + 1] = t;
        }
        // for (i = 0; i <= lastIndex; i++)
        //     printf("%d\t", a[i]);

        lastIndex++;
    }

    printf("\nThe Sorted array is :");
    for (i = 0; i < lastIndex; i++)
        printf("%d ", a[i]);
    float median;
    if (lastIndex % 2 != 0)
        median = a[lastIndex / 2];
    else
        median = (a[lastIndex / 2] + a[lastIndex / 2 - 1]) / 2.0;
    printf("\nThe median of the sorted array: %.2f", median);
    printf("\nThe average of the sorted array: %.2f", sum / lastIndex);
    return 0;
}

Output:

In case You have any doubt feel free to ask .If you are Satisfied with answer please upvote Thanks.