Question

Hey, so i am trying to have my program read a text file using a structure but i also want to be able to modify the results(I kinda have this part but it could be better). I cant seem to get it to read the file(all the values come up as 0 and i'm not sure why because in my other program where it wrote to the txt file the values are on the txt file) i copied and pasted the txt file into the same folder as this program so i thought it would work, any help is greatly appreciated.

(C++ Visual Studio 2017)

#include <iostream>  
#include <iomanip>  
#include <string>  
#include <fstream>

using namespace std;

string strFilename = "";
struct nah
{
   int intProductid = 0;
   int intQuantity = 0;
   float flSellprice = 0;
   float flProductcost = 0;
   float flProfit = 0;
   int intProductid2 = 0;
   int intQuantity2 = 0;
   float flSellprice2 = 0;
   float flProductcost2 = 0;
   char chChoice = ' ';
}numbers;

int main()
{
   cout << "***********************************************" << endl;
   cout << "** Enter the file name you want to read from **" << endl;
   cout << "***********************************************" << endl;
   cin >> strFilename;
   system("cls");

   ifstream in(strFilename.c_str());
   if (!in.fail())
   {
       cout << "File Read Error, try again after a bit" << endl;
       system("cls");
   }
   else
   {
       in >> numbers.intProductid;
       in >> numbers.flProductcost;
       in >> numbers.intQuantity;
       in >> numbers.flSellprice;
       cout << "*********************************" << endl;
       cout << "Product ID: " << numbers.intProductid << endl;
       cout << "Product Cost: " << numbers.flProductcost << endl;
       cout << "Quantity: " << numbers.intQuantity << endl;
       cout << "Sell Price: " << numbers.flSellprice << endl;
       cout << "*********************************" << endl;
       system("pause");
       system("cls");
   }

   do
   {
       cout << "\t\t--Menu--" << endl;
       cout << "1) Edit Output" << endl;
       cout << "2) New Output" << endl;
       cout << "e) Exit" << endl;
       cin >> numbers.chChoice;
       system("cls");

       switch (numbers.chChoice)
       {
       case '1':
           cout << "--Here is the current output--" << endl;
           cout << "*********************************" << endl;
           cout << "Product ID: " << numbers.intProductid << endl;
           cout << "Product Cost: " << numbers.flProductcost << endl;
           cout << "Quantity: " << numbers.intQuantity << endl;
           cout << "Sell Price: " << numbers.flSellprice << endl;
           cout << "*********************************" << endl;
           cout << "Please enter the changes you would like to make "
               << "(if no changes are to be made"
               << " please enter the same value)" << endl;
           cout << "Productid: ";
           cin >> numbers.intProductid2;
           cout << "Product Cost: ";
           cin >> numbers.flProductcost2;
           cout << "Quantity: ";
           cin >> numbers.intQuantity2;
           cout << "Sell Price: ";
           cin >> numbers.flSellprice2;
           system("cls");

       case '2':
           cout << "--Here is your new output after edits--" << endl;
           cout << "Product ID: " << numbers.intProductid2 << endl;
           cout << "Product Cost: " << numbers.flProductcost2 << endl;
           cout << "Quantity: " << numbers.intQuantity2 << endl;
           cout << "Sell Price: " << numbers.flSellprice2 << endl;

       case 'E':

       case 'e': //Exit
           break;

       default:
           cout << "*****************************" << endl;
           cout << "** pick a different option **" << endl;
           cout << "*****************************" << endl;
           system("pause");
           system("cls");
           break;
       }
   } while (numbers.chChoice != 'E' && numbers.chChoice != 'e');

   return 0;
}

Answer 1

`Hey,

Note: Brother in case of any queries, just comment in box I would be very happy to assist all your queries

Below is the corrected code. The problem was it was having !in.fail() in the if statement

#include <iostream>
#include <iomanip>
#include <string>
#include <fstream>
#include<cstdlib>

using namespace std;

string strFilename = "";
struct nah
{
int intProductid = 0;
int intQuantity = 0;
float flSellprice = 0;
float flProductcost = 0;
float flProfit = 0;
int intProductid2 = 0;
int intQuantity2 = 0;
float flSellprice2 = 0;
float flProductcost2 = 0;
char chChoice = ' ';
}numbers;

int main()
{
cout << "***********************************************" << endl;
cout << "** Enter the file name you want to read from **" << endl;
cout << "***********************************************" << endl;
cin >> strFilename;
system("cls");

ifstream in(strFilename.c_str());
if (in.fail())
{
cout << "File Read Error, try again after a bit" << endl;
system("cls");
}
else
{
in >> numbers.intProductid;
in >> numbers.flProductcost;
in >> numbers.intQuantity;
in >> numbers.flSellprice;
cout << "*********************************" << endl;
cout << "Product ID: " << numbers.intProductid << endl;
cout << "Product Cost: " << numbers.flProductcost << endl;
cout << "Quantity: " << numbers.intQuantity << endl;
cout << "Sell Price: " << numbers.flSellprice << endl;
cout << "*********************************" << endl;
system("pause");
system("cls");
}

do
{
cout << "\t\t--Menu--" << endl;
cout << "1) Edit Output" << endl;
cout << "2) New Output" << endl;
cout << "e) Exit" << endl;
cin >> numbers.chChoice;
system("cls");

switch (numbers.chChoice)
{
case '1':
cout << "--Here is the current output--" << endl;
cout << "*********************************" << endl;
cout << "Product ID: " << numbers.intProductid << endl;
cout << "Product Cost: " << numbers.flProductcost << endl;
cout << "Quantity: " << numbers.intQuantity << endl;
cout << "Sell Price: " << numbers.flSellprice << endl;
cout << "*********************************" << endl;
cout << "Please enter the changes you would like to make "
<< "(if no changes are to be made"
<< " please enter the same value)" << endl;
cout << "Productid: ";
cin >> numbers.intProductid2;
cout << "Product Cost: ";
cin >> numbers.flProductcost2;
cout << "Quantity: ";
cin >> numbers.intQuantity2;
cout << "Sell Price: ";
cin >> numbers.flSellprice2;
system("cls");

case '2':
cout << "--Here is your new output after edits--" << endl;
cout << "Product ID: " << numbers.intProductid2 << endl;
cout << "Product Cost: " << numbers.flProductcost2 << endl;
cout << "Quantity: " << numbers.intQuantity2 << endl;
cout << "Sell Price: " << numbers.flSellprice2 << endl;

case 'E':

case 'e': //Exit
break;

default:
cout << "*****************************" << endl;
cout << "** pick a different option **" << endl;
cout << "*****************************" << endl;
system("pause");
system("cls");
break;
}
} while (numbers.chChoice != 'E' && numbers.chChoice != 'e');

return 0;
}

Kindly revert for any queries

Thanks.