Question

I need to use the verify method I have built in the Employee class and check if the salary falls in the range. If not I shouldn't store it in the array. I have tried various ways but it still gets stored in the array...

here is my employee class: https://pastebin.com/iLzTuWe4

here is my test class: https://pastebin.com/Z33Q6h8E

Answer 1

/**
*
* @author Ivan Filipov
* @version 28Jun2019
*/
/*
* Mistake you have made is you have create an object in array itself.
* array[i] = new Employee(name, salary);
*    above statement will insert this object with valid/invalid data in array.
* but if it is invalid you are not removing it.
* that's why it's inserting.
* first you store it in a Employee object separately.
* then verify that object, it it is valid
* then put it in array.
* While inserting array[i] is used. if you give an invalid data
* i will increment, and and the next valid object will be in incremented i position.
*   so, increment i only if valid details are given.
*
*/
import javax.swing.JOptionPane;

public class TestEmployee {
  
   public static void main(String[] args) {
              
   String name;
   int salary;
   int numberOfEmployees;
  
   numberOfEmployees = Integer.parseInt(JOptionPane.showInputDialog("Enter the number of employees: " ));

   Employee[] array = new Employee[numberOfEmployees];{      
      
       for(int i = 0; i < numberOfEmployees; )//don't increment i for each execution of statments in for loop.
       {
           //increment i only if valid data is entered.
          
           name = JOptionPane.showInputDialog("Enter name of employee " + (i+1));
           salary = Integer.parseInt(JOptionPane.showInputDialog("Enter the salary of the employee " + (i+1)));
           //create an employee object
           Employee emp = new Employee(name, salary);
           //verify the emp object
           if(emp.verify())
           {
               //if valid insert in employee object
               array[i] = emp;
               //increment the i
               i++;
           }
           else
           {
               JOptionPane.showMessageDialog(null, "The salary should be 1000 - 99999$");
           }
           //check here only emp object
           if(emp.name.equals("FINISH"))
           {
               break;
           }      
       }
       String result = "";
       for(int i = 0; i < numberOfEmployees; i++)
       {
           result += "\n" + array[i].name + " $ " + array[i].salary;
       }
       JOptionPane.showMessageDialog(null, "Employee     Salary" + "\n ------   -------"
   + result);  
       }  
   }
}

//Employee.java

/**
*
* @author Ivan Filipov
* @version 28Jun2019
*/
public class Employee {

String name;
int salary;

Employee(String name, int salary){

this.name = name;
this.salary = salary;
}

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

public int getSalary() {
return salary;
}

public void setSalary(int salary) {
this.salary = salary;
}
public boolean verify() {
if(this.salary < 1000 || this.salary > 99999) {
return false;
}else {
return true;
}
}
}

//outputs