Question

Can somebody help me with this coding

the program allow 2 players play tic Tac Toe.

however, mine does not take a turn. after player 1 input the tow and column the program eliminated.

I want this program run until find a winner.

also can somebody add function 1 player vs computer mode as well?

Thanks!

>>>>>>>>>>>>>Main program >>>>>>>>>>>>>>>>>>>>>>>

#include "myheader.h"

int main()

{

const int NUM_ROWS = 3;

const int NUM_COLS = 3;

// Variables

bool again;

bool won;

char board[NUM_ROWS][NUM_COLS];

char token;

string player1;

string player2;

won = false;

again = true;

InitBoard(board);

OutputInstruct();

GetPlayers(player1, player2);

token = 'X';

do {

while(!won)

{

GetAndCheckInp(board, token, player1, player2);

if (CheckWin(board) != 'N')

{

won = true;

}

DisplayBoard(board);

SwitchToken(token);

}

} while(again);

return 0;

}

///////////////////HEADER //////////////////////

#ifndef MYHEADER_H_

#define MYHEADER_H_

#include<iostream>

#include<iomanip>

#include<cstdlib>

using namespace std;

const int NUM_ROWS = 3;

const int NUM_COLS = 3;

int sum;

void OutputInstruct()

{

cout << "Play the game"<<endl;

}

/******************************************************************************

* InitBoard

* This function initializes each spot in the board to a space ' '.

* RETURNS: Board initialized with all spaces

*****************************************************************************/

void InitBoard(char board[][3]) // tic tac toe board – OUT

{

for(int i = 0; i <= NUM_ROWS; i++)

for(int j = 0; j <= 3; j++)

board[i][j] = ' ';

}

/******************************************************************************

* DisplayBoard

* This function outputs the tic tac toe board including the tokens

* played in the proper format (as described below).

1 2 3

1[1][1]. [1][2]. [1][3]

2[2][1]. [2][2]. [2][3]

3[3][1]. [3][2]. [3][3]

* RETURNS: nothing

* Outputs the current state of the board

*****************************************************************************/

void DisplayBoard(const char board[][3]) // tic tac toe board

{

cout << setw(10) << "1" << setw(8) << "2" << setw(9) << "3\n";

for (int i=0; i < 3; i++)

{

cout << setw(7)<< "[" << i+1 << "][1] | " << "[" << i+1;

cout << "][2] | " << "[" << i+1 << "][3]" << endl;

cout << setw(14)<< "|" << setw(9) << "|" << endl;

for (int j = 0; j < 3; j++)

{

switch(j)

{

case 0: cout << i + 1 << setw(9) << board[i][j];

cout << setw(4) << "|";

break;

case 1: cout << setw(4) << board[i][j];

cout << setw(5) << "|";

break;

case 2: cout << setw(4) << board[i][j] << endl;

break;

default: cout <<"ERROR!\n\n";

}

}

cout << setw(14)<< "|" << setw(10) << "|\n";

if (i != 2)

{

cout << setw(32) << "--------------------------\n";

}

}

cout << endl << endl;

}

/******************************************************************************

* GetPlayers

* This function prompts the user and gets the input for the players’ names.

* player1 contains the name of the player that is using the X token.

* player2 contains the name of the player that is using the O token.

*

* RETURNS: the token opposite of the one in which it receives.

*****************************************************************************/

void GetPlayers(string& player1, string& player2)

{

cout << "Enter the name of player 1(X) : ";

getline (cin, player1);

cout << "Enter the name of player 2(O) : ";

getline (cin, player2);

}

void GetAndCheckInp(char board[][3], char token, string player1, string player2)

{

int row;

int col;

bool valid;

do

{

if (token == 'X')

{

cout << player1 << "'s turn What's your play? : "<<endl;

cout << "Row? : "<<endl;

cin >> row;

cout << "Column? : "<<endl;

cin >> col;

}

else if (token == 'O')

{

cout << player2 << "'s turn: What's your play?"<<endl;

cout << "Row? : "<<endl;

cin >> row;

cout << "Column? : "<<endl;

cin >> col;

}

row--;

col--;

if ((row > NUM_ROWS || row < 0) || (col > 3 || col < 0))

{

valid = false;

cout << "Please chose a space on the board." << endl;

}

else if (board[row][col] != ' ')

{

valid = false;

cout << "That space is already taken, choose another"<<endl;

}

else

{

valid = true;

board[row][col] = token;

sum++;

}

} while (!valid);

}

/******************************************************************************

* SwitchToken

*

* RETURNS: the token opposite of the one in which it receives.

*****************************************************************************/

char SwitchToken(char token) // current player’s token ('X' or 'O') - IN

{

if (toupper(token) == 'X')

{

token = 'O';

}

else if (toupper(token) == 'O')

{

token = 'X';

}

}

/******************************************************************************

* CheckWin

* This function checks to see if either player has won.

* RETURNS the character value of the player that won or T if it was a tie

* or N if no won

*****************************************************************************/

char CheckWin(const char board[][3]) // tic tac toe board - IN

{

int win = 0;

// Checks for three same value horizental

for (int i = 0; i < 3; i++)

if (board[i][0] == board[i][1] && board[i][1] == board[i][2]) win = board[i][0];

// Checks for three same value vertical

for (int i = 0; i < 3; i++)

if (board[0][i] == board[1][i] && board[1][i] == board[2][i]) win = board[0][i];

// Checks for three same value diagnal

if ((board[0][0] == board[1][1] && board[1][1] == board[2][2]) || (board[0][2] == board[1][1] && board[1][1] == board[2][0]))

win = board[1][1];

return win;

}

/******************************************************************************

* OutputWinner

*

* RETURNS: nothing

* Displays the winner’s name

*****************************************************************************/

void OutputWinner(char whoWon, string player1, string player2)

{

if (whoWon == 'X')

{

cout << player1 << " has won the game"<<endl;

}

else if (whoWon == 'O')

{

cout << player2 << " has won the game"<<endl;;

}

else if (whoWon == 'T')

{

cout << player1 << " and " << player2 << " have tied"<<endl;;

}

}

#endif

Answer 1

After fixing all the bugs and making your code working is:

///////////////////HEADER //////////////////////​​​​​​​

#ifndef MYHEADER_H_
#define MYHEADER_H_
#include<iostream>
#include<iomanip>
#include<cstdlib>

using namespace std;

const int NUM_ROWS = 3;
const int NUM_COLS = 3;

int sum;

void OutputInstruct()
{
   cout << "\nPlay the game\n"<<endl;
}

/******************************************************************************
* InitBoard
* This function initializes each spot in the board to a space ' '.
* RETURNS: Board initialized with all spaces
*****************************************************************************/

void InitBoard(char board[][3]) // tic tac toe board – OUT
{
   for(int i = 0; i <= NUM_ROWS; i++)
       for(int j = 0; j <= 3; j++)
           board[i][j] = ' ';
}

/******************************************************************************
* DisplayBoard
* This function outputs the tic tac toe board including the tokens
* played in the proper format (as described below).

   1        2        3
1[1][1]. [1][2]. [1][3]
2[2][1]. [2][2]. [2][3]
3[3][1]. [3][2]. [3][3]

* RETURNS: nothing
* Outputs the current state of the board
*****************************************************************************/

void DisplayBoard(const char board[][3]) // tic tac toe board
{
   cout << setw(10) << "1" << setw(8) << "2" << setw(9) << "3\n";
   for (int i=0; i < 3; i++)
   {
       cout << setw(7)<< "[" << i+1 << "][1] | " << "[" << i+1;
       cout << "][2] | " << "[" << i+1 << "][3]" << endl;
       cout << setw(14)<< "|" << setw(9) << "|" << endl;

       for (int j = 0; j < 3; j++)
       {
           switch(j)
           {
               case 0: cout << i + 1 << setw(9) << board[i][j];
               cout << setw(4) << "|";
               break;

               case 1: cout << setw(4) << board[i][j];
               cout << setw(5) << "|";
               break;

               case 2: cout << setw(4) << board[i][j] << endl;
               break;

               default: cout <<"ERROR!\n\n";
           }
       }

       cout << setw(14)<< "|" << setw(10) << "|\n";
       if (i != 2)
       {
       cout << setw(32) << "--------------------------\n";
       }
   }
   cout << endl << endl;
}

/******************************************************************************
* GetPlayers
* This function prompts the user and gets the input for the players’ names.
* player1 contains the name of the player that is using the X token.
* player2 contains the name of the player that is using the O token.
*
* RETURNS: the token opposite of the one in which it receives.
*****************************************************************************/

void GetPlayers(string& player1, string& player2)
{
   cout << "\nEnter the name of player 1(X) : ";
   getline (cin, player1);
   cout << "Enter the name of player 2(O) : ";
   getline (cin, player2);
}

void GetAndCheckInp(char board[][3], char token, string player1, string player2)
{
   int row;
   int col;
   bool valid;

   do
   {
       if (token == 'X')
       {
           cout << player1 << "'s turn What's your play? : "<<endl;

           cout << "Row? : "<<endl;
           cin >> row;

           cout << "Column? : "<<endl;
           cin >> col;
       }

       else if (token == 'O')
       {
           cout << player2 << "'s turn: What's your play?"<<endl;

           cout << "Row? : "<<endl;
           cin >> row;

           cout << "Column? : "<<endl;
           cin >> col;
       }

       row--;
       col--;

       if ((row > NUM_ROWS || row < 0) || (col > 3 || col < 0))
       {
           valid = false;
           cout << "Please chose a space on the board." << endl;
       }

       else if (board[row][col] != ' ')
       {
           valid = false;
           cout << "That space is already taken, choose another"<<endl;
       }

       else
       {
           valid = true;
           board[row][col] = token;
           sum++;
       }

   } while (!valid);
}

/******************************************************************************
* SwitchToken
*
* RETURNS: the token opposite of the one in which it receives.
*****************************************************************************/

char SwitchToken(char token) // current player’s token ('X' or 'O') - IN
{
   if (toupper(token) == 'X')
   {
       token = 'O';
   }

   else if (toupper(token) == 'O')
   {
       token = 'X';
   }

   return token;
}

/******************************************************************************
* CheckWin
* This function checks to see if either player has won.
* RETURNS the character value of the player that won or T if it was a tie
* or N if no won
*****************************************************************************/

char CheckWin(const char board[][3]) // tic tac toe board - IN
{
   char win = ' ';

   // Checks for three same value horizental
   for (int i = 0; i < 3; i++)
       if (board[i][0] == board[i][1] && board[i][1] == board[i][2]) return board[i][0];

   // Checks for three same value vertical
   for (int i = 0; i < 3; i++)
       if (board[0][i] == board[1][i] && board[1][i] == board[2][i]) return board[0][i];

   // Checks for three same value diagnal
   if ((board[0][0] == board[1][1] && board[1][1] == board[2][2]) || (board[0][2] == board[1][1] && board[1][1] == board[2][0]))
       return board[1][1];

   // Checks if there is any square left
   for (int i = 0; i < 3; i++)
       for (int j = 0; j < 3; j++)
           if (board[i][j] == ' ')
               return ' ';

   // returns draw
   return 'T';
}

/******************************************************************************
* OutputWinner
*
* RETURNS: nothing
* Displays the winner’s name
*****************************************************************************/

void OutputWinner(char whoWon, string player1, string player2)
{
   if (whoWon == 'X')
   {
       cout << player1 << " has won the game"<<endl;
   }

   else if (whoWon == 'O')
   {
       cout << player2 << " has won the game"<<endl;;
   }

   else if (whoWon == 'T')
   {
       cout << player1 << " and " << player2 << " have tied"<<endl;;
   }
}

#endif

>>>>>>>>>>>>>Main program >>>>>>>>>>>>>>>>>>>>>>>

#include "myheader.h"

int main()
{
   const int NUM_ROWS = 3;
   const int NUM_COLS = 3;

   // Variables
   string player1;
   string player2;

   GetPlayers(player1, player2);

   bool again;

   do
   {
       // Variables
       bool won;
       char board[NUM_ROWS][NUM_COLS];
       char token;
       char input;

       won = false;
       again = true;

       InitBoard(board);
       OutputInstruct();

       token = 'O';

       while(!won)
       {
           token = SwitchToken(token);
           GetAndCheckInp(board, token, player1, player2);

           if (CheckWin(board) != ' ')
           {
               won = true;
           }

           DisplayBoard(board);
       }

       OutputWinner(CheckWin(board), player1, player2);

       //asking user to play again
       cout<<"\nPlay again? (Y/N) : ";
       cin>>input;

       again = toupper(input)=='Y';

   } while(again);

   return 0;
}

MYHEADER ProgramScreenshots:

MAIN Program Screenshots:

Output Screenshots: