Question

Can some help me with my code I'm not sure why its not working. Thanks

In this exercise, you are to modify the Classify Numbers programming
example in this chapter. As written, the program inputs the data from the
standard input device (keyboard) and outputs the results on the standard
output device (screen). The program can process only 20 numbers. Rewrite
the program to incorporate the following requirements:

a. Data to the program is input from a file of an unspecified length; that is,
the program does not know in advance how many numbers are in the file.

b. Save the output of the program in a file.

c. Modify the function getNumber so that it reads a number from the
input file (opened in the function main), outputs the number to the
output file (opened in the function main), and sends the number read
to the function main. Print only 10 numbers per line.

d. Have the program find the sum and average of the numbers.

e. Modify the function printResult so that it outputs the final results to
the output file (opened in the function main). Other than outputting the
appropriate counts, this new definition of the function printResult
should also output the sum and average of the numbers.

#include <iostream>
#include <fstream>
#include <cstdlib>

using namespace std;

void initialize(int& zeroCount, int& oddCount, int& evenCount);
void getNumber(ifstream& in, ofstream& out, int& num);
void classifyNumber(int num, int& zeroCount, int& oddCount, int evenCount);
void printResults(ofstream& out, int zeroCount, int oddCount, int evenCount, int sum);

int main()
{
int counter;
int number;
int zeros;
int odds;
int evens;
int sum = 0;
char fileName[15];

ifstream inFile;
ofstream outFile;

cout << "\n\n\tProgram that classifies numbers.";

cout << "\n\n\tEnter the input file name: ";
cin >> fileName;

inFile.open(fileName);

if (!inFile.is_open())
{
cout << "\n\n\tError in opening input file";
exit(0);
}

cout << "\tEnter the output file name:";
cin >> fileName;

outFile.open(fileName);

if (!outFile.is_open())
{
cout << "\n\n\tError in opening input file";
exit(0);
}

initialize(zeros, odds, evens);

counter = 0;
while (true)
{
getNumber(inFile, outFile, number);

if (!inFile)
break;

sum += number;
counter++;

if ((counter % 10) == 0)
outFile << endl;
  
classifyNumber(number, zeros, odds, evens);
}

printResults(outFile, zeros, odds, evens, sum);

return 0;

}

void initialize(int& zeroCount, int& oddCount, int& evenCount)
{
zeroCount = 0;
oddCount = 0;
evenCount = 0;
}

void getNumber(ifstream& in, ofstream& out, int& num)
{
if ((in >> num) != NULL)
out << num << "\t";
}

void classifyNumber(int num, int& zeroCount, int& oddCount, int& evenCount)
{
switch (num % 2)
{
case 0:
evenCount++;

if (num == 0);
zeroCount++;
break;
case 1:
case -1:
oddCount++;
}

}

void printResults(ofstream& out, int zeroCount, int oddCount, int evenCount, int sum)

{
double avg = (sum * 1.0) / (oddCount + evenCount);

out << "\nThere are " << evenCount << "evens" << "which includes" << zeroCount << "zeros.";
out << "\nThe number of odd numbers is : " << oddCount;
out << "\nThe sum of the above numbers is : " << sum;
out << "\nThe average of the above numbers is " << avg;
}

Answer 1

// I have corrected the errors. Please use the below code.

#include <iostream>
#include <fstream>
#include <cstdlib>

using namespace std;

void initialize(int& zeroCount, int& oddCount, int& evenCount);
void getNumber(ifstream& in, ofstream& out, int& num);
void classifyNumber(int num, int& zeroCount, int& oddCount, int& evenCount);
void printResults(ofstream& out, int zeroCount, int oddCount, int evenCount, int sum);

int main()
{
int counter;
int number;
int zeros;
int odds;
int evens;
int sum = 0;
char fileName[15];

ifstream inFile;
ofstream outFile;

cout << "\n\n\tProgram that classifies numbers.";

cout << "\n\n\tEnter the input file name: ";
cin >> fileName;

inFile.open(fileName);

if (!inFile.is_open())
{
cout << "\n\n\tError in opening input file";
exit(0);
}

cout << "\tEnter the output file name:";
cin >> fileName;

outFile.open(fileName);

if (!outFile.is_open())
{
cout << "\n\n\tError in opening input file";
exit(0);
}

initialize(zeros, odds, evens);

counter = 0;
while (true)
{
getNumber(inFile, outFile, number);

if (!inFile)
break;

sum += number;
counter++;

if ((counter % 10) == 0)
outFile << endl;
  
classifyNumber(number, zeros, odds, evens);
}

printResults(outFile, zeros, odds, evens, sum);

return 0;

}

void initialize(int& zeroCount, int& oddCount, int& evenCount)
{
zeroCount = 0;
oddCount = 0;
evenCount = 0;
}

void getNumber(ifstream& in, ofstream& out, int& num)
{
if ((in >> num) != NULL)
out << num << "\t";
}

void classifyNumber(int num, int& zeroCount, int& oddCount, int& evenCount)
{
switch (num % 2)
{
case 0:
evenCount++;
if (num == 0)
zeroCount++;
break;
case 1:
oddCount++;
}

}

void printResults(ofstream& out, int zeroCount, int oddCount, int evenCount, int sum)

{
double avg = (sum * 1.0) / (oddCount + evenCount);

out << "\nThere are " << evenCount << " evens" << " which includes " << zeroCount << " zeros.";
out << "\nThe number of odd numbers is : " << oddCount;
out << "\nThe sum of the above numbers is : " << sum;
out << "\nThe average of the above numbers is " << avg;
}

- o X input.txt - Notepad File Edit Format View Help 10 65 26 85 1 5 98 44

-ox output.txt - Notepad File Edit Format View Help 10 65 0 15 51 - 57 70 259 43 23 44 26 99 85 89 30 47 77 16 There are 8 evens which includes 1 zeros. The number of odd numbers is : 12 The sum of the above numbers is : 848 The average of the above numbers is 42.4

C:\Users\sai-6993\Desktop\test.exe - 9 X Program that classifies numbers. Enter the input file name: input.txt Enter the output file name:output.txt Process exited after 8.837 seconds with return value o Press any key to continue ...,