Question

can someone help me fix this. The function that finds the minimum and maximum values of the array and outputs the value and index doesnt find the maximum value of the array.

#include <iostream>
#include <fstream>
#include<iomanip>

using namespace std;
void readArray(ifstream& inF, int arr[], int&ArrSize);
void writeArray(ofstream & outF, int arr[], int & ArrSize);
void MaxAndMin(ofstream & outF, int arr[], int & ArrSize, int &high, int &low);
int main()
{
   int arr[100];
   int i = 0;
   int size = 0;
   int high = 0, low = 0;
   ifstream inFile;
   inFile.open("integers.txt");
   ofstream outFile;
   outFile.open("arresults.txt");
   readArray(inFile, arr, size);
   writeArray(outFile, arr, size);
   MaxAndMin(outFile, arr, size, high, low);
   return 0;
}

void readArray(ifstream & inF, int arr[], int & ArrSize)
{

   int x;
   while (!inF.eof())
   {
       inF >> x;
       arr[ArrSize] = x;
       ArrSize++;
   }
   cout << "\nArray elements: \n";
   for (int i = 0; i < ArrSize; i++)
   {
       cout << arr[i] << endl;
   }
   // Close input file
   inF.close();
}

void writeArray(ofstream & outF, int arr[], int & ArrSize)
{

   //outputs 10 integers per line
   for (int i = 0; i <= ArrSize; i++)
   {
       outF << arr[i] << " ";
       if ((i) % 10 == 9)
           outF << endl;
   }
}

void MaxAndMin(ofstream & outF, int arr[], int & ArrSize, int &high, int &low)
{
   int i;
   //finds index of smallest and largest value in array//
   for (i = 0; i <= ArrSize; i++)
   {
       if (arr[i] > arr[high])
           high = arr[i];
       else
           if (arr[i]<arr[low])
           low = arr[i];
   }
   outF << "The highest value is " << high << " at index " <<arr[high] << endl;
   outF << "The lowest value is " << low<< " at index " << arr[low] << endl;

}

Answer 1

#include <iostream>
#include <fstream>
#include<iomanip>

using namespace std;
void readArray(ifstream& inF, int arr[], int&ArrSize);
void writeArray(ofstream & outF, int arr[], int & ArrSize);
void MaxAndMin(ofstream & outF, int arr[], int & ArrSize, int &high, int &low);
int main()
{
int arr[100];
int size = 0;
int high = 0, low = 0;
ifstream inFile;
inFile.open("integers.txt");
ofstream outFile;
outFile.open("arresults.txt");
readArray(inFile, arr, size);
writeArray(outFile, arr, size);
MaxAndMin(outFile, arr, size, high, low);
return 0;
}

void readArray(ifstream & inF, int arr[], int & ArrSize)
{

int x;
while (inF >> x)
{
arr[ArrSize] = x;
ArrSize++;
}
cout << "\nArray elements: \n";
for (int i = 0; i < ArrSize; i++)
{
cout << arr[i] << endl;
}
// Close input file
inF.close();
}

void writeArray(ofstream & outF, int arr[], int & ArrSize)
{

//outputs 10 integers per line
for (int i = 0; i < ArrSize; i++)
{
outF << arr[i] << " ";
if ((i) % 10 == 9)
outF << endl;
}
}

void MaxAndMin(ofstream & outF, int arr[], int & ArrSize, int &high, int &low)
{
int i;
// Initialize highValue and lowValue to first element
int highValue = arr[0];
int lowValue = arr[0];
//finds index of smallest and largest value in array//
for (i = 1; i < ArrSize; i++)
{
// Check if highValue < value at index i
// If yes, set highValue to arr[i]
// Set index high = i
if (highValue<arr[i])
{
highValue = arr[i];
high = i;
}
// Check if lowValue > value at index i
// If yes, set lowValue to arr[i]
// Set index low = i
if (lowValue > arr[i])
{
lowValue = arr[i];
low = i;
}

}
outF << "The highest value is " << highValue << " at index " <<high << endl;
outF << "The lowest value is " << lowValue<< " at index " << low << endl;
}

OUTPUT-