Question

Greetings everyone I am having a little trouble with this one. I bolded my switch case which should work but its currently not. If a user selected course option 1 twice it just says you enrolled in course 1 and course 1. It should stop it by executing case -2. Need a new set of eyes. - Thanks

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace ConsoleRegisterStudent
{
class Program
{
static void Main(string[] args)
{
(new Program()).run();
}

void run()
{
int choice;
int firstChoice = 0, secondChoice = 0, thirdChoice = 0;
int totalCredit = 0;
string yesOrNo = "";

System.Console.WriteLine("Ayala's Copy");

do
{
WritePrompt();
choice = Convert.ToInt32(Console.ReadLine());

switch (ValidateChoice(choice, firstChoice, secondChoice, thirdChoice, totalCredit))
{
case -1:
Console.WriteLine("Your entered selection {0} is not a recognized course.", choice);
break;
case -2:
Console.WriteLine("You have already registerd for this {0} course.", ChoiceToCourse(choice));
break;
case -3:
Console.WriteLine("You can not register for more than 9 credit hours.");
break;
case 0:
Console.WriteLine("Registration Confirmed for course {0}.", ChoiceToCourse(choice));
totalCredit += 3;
if (firstChoice == 0)
firstChoice = choice;
else if (secondChoice == 0)
secondChoice = choice;
else if (thirdChoice == 0)
thirdChoice = choice;
break;
}

WriteCurrentRegistration(firstChoice, secondChoice, thirdChoice);
Console.Write("\nDo you want to try again? (Y|N)? : ");
yesOrNo = (Console.ReadLine()).ToUpper();
} while (yesOrNo == "Y");

Console.WriteLine("Thank you for registering with us");
}

void WritePrompt()
{
Console.WriteLine("Please select a course for which you want to register by typing the number inside []");
Console.WriteLine("[1]IT 145\n[2]IT 200\n[3]IT 201\n[4]IT 270\n[5]IT 315\n[6]IT 328\n[7]IT 330");
Console.Write("Enter your choice : ");
}

int ValidateChoice(int choice, int firstChoice, int secondChoice, int thirdChoice, int totalCredit)
{
//changed from 70 to 7 and return -4 to 0
if (choice < 1 || choice > 7)
return -1;
else if (choice == firstChoice && choice == secondChoice && choice == thirdChoice)
return -2;
else if (totalCredit > 9)
return -3;
return 0;
}

void WriteCurrentRegistration(int firstChoice, int secondChoice, int thirdChoice)
{
if (secondChoice == 0)
Console.WriteLine("You are currently registered for {0}", ChoiceToCourse(firstChoice));
else if (thirdChoice == 0)
Console.WriteLine("You are currently registered for {0}, {1}", ChoiceToCourse(firstChoice), ChoiceToCourse(secondChoice));
else
Console.WriteLine("You are currently registered for {0}, {1}, {2}", ChoiceToCourse(firstChoice), ChoiceToCourse(secondChoice), ChoiceToCourse(thirdChoice));
}

string ChoiceToCourse(int choice)
{
string course = "";
switch (choice)
{
case 1:
course = "IT 145";
break;
case 2:
course = "IT 200";
break;
case 3:
course = "IT 201";
break;
case 4:
course = "IT 270";
break;
case 5:
course = "IT 315";
break;
case 6:
course = "IT 328";
break;
case 7:
course = "IT 330";
break;
default:
break;
}
return course;
}
}
}

Answer 1

Here there is only a simple mistake , && operation is used in the place where || operation is needed.

Corrected code

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace ConsoleRegisterStudent
{
class Program
{
static void Main(string[] args)
{
(new Program()).run();
}

void run()
{
int choice;
int firstChoice = 0, secondChoice = 0, thirdChoice = 0;
int totalCredit = 0;
string yesOrNo = "";

System.Console.WriteLine("Ayala's Copy");

do
{
WritePrompt();
choice = Convert.ToInt32(Console.ReadLine());

switch (ValidateChoice(choice, firstChoice, secondChoice, thirdChoice, totalCredit))
{
case -1:
Console.WriteLine("Your entered selection {0} is not a recognized course.", choice);
break;
case -2:
Console.WriteLine("You have already registerd for this {0} course.", ChoiceToCourse(choice));
break;
case -3:
Console.WriteLine("You can not register for more than 9 credit hours.");
break;
case 0:
Console.WriteLine("Registration Confirmed for course {0}.", ChoiceToCourse(choice));
totalCredit += 3;
if (firstChoice == 0)
firstChoice = choice;
else if (secondChoice == 0)
secondChoice = choice;
else if (thirdChoice == 0)
thirdChoice = choice;
break;
}

WriteCurrentRegistration(firstChoice, secondChoice, thirdChoice);
Console.Write("\nDo you want to try again? (Y|N)? : ");
yesOrNo = Console.ReadLine();
yesOrNo=yesOrNo.ToUpper();
} while (yesOrNo == "Y");

Console.WriteLine("Thank you for registering with us");
}

void WritePrompt()
{
Console.WriteLine("Please select a course for which you want to register by typing the number inside []");
Console.WriteLine("[1]IT 145\n[2]IT 200\n[3]IT 201\n[4]IT 270\n[5]IT 315\n[6]IT 328\n[7]IT 330");
Console.Write("Enter your choice : ");
}

int ValidateChoice(int choice, int firstChoice, int secondChoice, int thirdChoice, int totalCredit)
{
//changed from 70 to 7 and return -4 to 0
if (choice < 1 || choice > 7)
return -1;
else if (choice == firstChoice || choice == secondChoice || choice == thirdChoice) //here && is replaced with ||
return -2;
else if (totalCredit > 9)
return -3;
return 0;
}

void WriteCurrentRegistration(int firstChoice, int secondChoice, int thirdChoice)
{
if (secondChoice == 0)
Console.WriteLine("You are currently registered for {0}", ChoiceToCourse(firstChoice));
else if (thirdChoice == 0)
Console.WriteLine("You are currently registered for {0}, {1}", ChoiceToCourse(firstChoice), ChoiceToCourse(secondChoice));
else
Console.WriteLine("You are currently registered for {0}, {1}, {2}", ChoiceToCourse(firstChoice), ChoiceToCourse(secondChoice), ChoiceToCourse(thirdChoice));
}

string ChoiceToCourse(int choice)
{
string course = "";
switch (choice)
{
case 1:
course = "IT 145";
break;
case 2:
course = "IT 200";
break;
case 3:
course = "IT 201";
break;
case 4:
course = "IT 270";
break;
case 5:
course = "IT 315";
break;
case 6:
course = "IT 328";
break;
case 7:
course = "IT 330";
break;
default:
break;
}
return course;
}
}
}

Screenshot of the code

$1596210799787_image.png$

35 break; 36 case -2: 37 Console.WriteLine("You have already registerd for this {m} course.", ChoiceToCourse (choice)); 38 break; 39 case -3: 40 Console.WriteLine("You can not register for more than 9 credit hours."); 41 break; 42 case 0: 43 Console.WriteLine("Registration Confirmed for course {0}.", ChoiceToCourse(choice)); 44 totalCredit += 3; 45 if (firstChoice == 0) 46 firstChoice = choice; 47 else if (secondChoice 48 secondChoice choice; 49 else if (thirdChoice == 0) 50 thirdChoice = choice; 51 break; 52 } 53 54 WriteCurrentRegistration(firstChoice, secondChoice, thirdChoice); 55 Console.Write("\nDo you want to try again? (YN)? : "); 56 yesOrNo = Console.ReadLine(); 57 yesOrNo=yesorNo.Toupper(); 58 } while (yesorNo == "Y"); 59 60 Console.WriteLine("Thank you for registering with us"); 61 } 62 63 void WritePrompt() 64 { 65 Console.WriteLine("Please select a course for which you want to register typing the number inside []"); 66 Console.WriteLine("[1]IT 145\n[2]IT 200\n [3]IT 201\n[4]IT 270\n [5]IT 315\n [6]IT 328\n [7]IT 330"); 67 Console.Write("Enter your choice : ");

$1596210838043_image.png$

101 case 2: 102 course = "IT 200"; 103 break; 104 case 3: 105 course = "IT 201"; 106 break; 107 case 4: 108 course = "IT 270"; 109 break; 110 case 5: 111 course = "IT 315"; 112 break; 113 case 6: 114 course = "IT 328"; 115 break; 116 case 7: 117 course = "IT 330"; 118 break; 119 default: 120 break; 121 } 122 return course; 123 } 124 } 125 }

Output

$1596210884879_image.png$

$1596210916441_image.png$

If you find this answer useful , please rate positive,thankyou