Question

Hello in C#. I need help understanding and knwoing what i missed in my program. The issue is, the program is supposed to have user input for 12 family members and at the end of the 12 it asks for user to input a name to search for. When i put a correct name, it always gives me a relative not found message. WHat did i miss. And can you adjust the new code so im able to see where it shouldve been.

Thabk you

using System;

namespace RelativesList

{

class Relative : IComparable

{

private string name;

private string relationship;

private int day;

private int month;

private int year;

public int CompareTo(object obj)

{

if (obj == null) return 1;

Relative reIOBJ = obj as Relative;

if (reIOBJ != null)

return this.Name.CompareTo(reIOBJ.Name);

else

throw new ArgumentException("Argument Exception");

}

public Relative()

{

name = "";

relationship = "";

day = 1;

month = 1;

year = 2001;

}

public string Name

{

get

{

return name;

}

set

{

name = value;

}

}

public string Relationship

{

get

{

return relationship;

}

set

{

relationship = value;

}

}

public int Day

{

get

{

return day;

}

set

{

day = value;

}

}

public int Month

{

get

{

return month;

}

set

{

month = value;

}

}

public int Year

{

get

{

return year;

}

set

{

year = value;

}

}

public override string ToString()

{

string output =

String.Format("Name {0} | Relationship:"

+ "{1} | DOB: {2:D2}-{3:D2}"

+ "-{4:D4}\n", name,

relationship, day, month, year);

return output;

}

}

class Program

{

static void Main(string[] args)

{

const int NUMBER = 12;

Relative[] relatives = new Relative[NUMBER];

for (int idx = 0; idx < NUMBER; idx++)

{

relatives[idx] = new Relative();

Console.Write("Enter name: ");

relatives[idx].Name = Console.ReadLine();

Console.Write("Enter relationship:");

relatives[idx].Relationship =

Console.ReadLine();

Console.Write("Enter day of birth: ");

relatives[idx].Day = Convert.ToInt16

(Console.ReadLine());

Console.Write("Enter month of birth: ");

relatives[idx].Month = Convert.ToInt16

(Console.ReadLine());

Console.Write("Enter year of birth: ");

relatives[idx].Year = Convert.ToInt16(Console.ReadLine());

Console.WriteLine();

}

Array.Sort(relatives);

Console.WriteLine("Relative Data sorted by name:\n");

for (int idx = 0; idx < NUMBER; idx++)

{

Console.WriteLine(relatives[idx].ToString());

}

Console.Write("\nEnter Relative's Name: ");

string name = Console.ReadLine();

int index = 0;

bool found = false;

for (index = 0; index < NUMBER; index++)

{

if (relatives[index].Name.CompareTo(name) == 0)

{

found = true;

break;

}

}

if (!found)

Console.WriteLine("Relative not found");

else

{

Console.WriteLine("Relationship: " + relatives[index].Relationship);

Console.WriteLine(

String.Format("DOB: {0}-{1}-{2}", relatives[index].Day, relatives[index].Month, relatives[index].Year));

}

Console.ReadKey();

}

}

}

Answer 1

The issue is very simple, The code doesn't handle the comparison to compare the same strings(names) in different cases.

For example: in the code given, If the relative name is "George" and the name to be searched is "george" it won't consider it as same.

The code has been checked with random input and found this is the issue.

The statement to be changed is the comparison statement

if (relatives[index].Name.CompareTo(name) == 0)

There are two ways to fix this issue:

1. To use any case conversion method (ToUpper() or ToLower)

2. To use Equals with StringComparison.OrdinalIgnoreCase

Using ToUpper and ToLower

This is a very common method used to compare strings as case insensitive.

The changed statement will be

Using Equals with StringComparison.OrdinalIgnoreCase

Hope this helps!!!