Question

I'm getting a segmentation fault for this function, this is for a c++ program. Is there anything that you see that is obviously wrong? Am i using cin.get wrong? Please help if you can.

number is my variable, and NUMBER is the const int limit

void questions::addQuestion()
{
   int i = 0;

   cout << "Enter the question number: " << endl; //after this line is where it seg faults
   cin.get(number,NUMBER, '\n');
   cin.ignore(100, '\n');

   cout << "Enter the subject of the question: " << endl;
   cin.get(subject, strlen(subject), '\n');
   cin.ignore(100, '\n');
   for(int i = 0; i < strlen(subject); ++i)
       subject[i] = toupper(subject[i]);

   cout <<"Enter the text of the question: " << endl;
   cin.get(text,TEXT);
   cin.ignore(100, '\n');

   cout <<"Enter the date of completion: " << endl;
   cin.get(date, DATE);
   cin.ignore(100, '\n');
}

Answer 1

Your doing wrong at the declaration of the variable therefore the compiler is not able to access your memory location and returns the seg fault.

As you have not passed any variable named number to addQuestion function and it has not been declared locally in the addQuestion function.

Therefore the problem lies in the declaration of the varialble and I suggest you to delcare all the varialbes in the function locally

as you know that cin.get takes string variable and you have to mention the size of the variable which you are taking at the runtime.correct usage of the cin.get(char *buffer, int length,'\n');

As you have mentioned the line where you are getting the seg fault i have modified upto that and I suggest you to please declare all the variable before their usage.(A small mistake every programmer does not declaring the variables).

code correction as per your mentioned line

#include <iostream>

using namespace std;

//Global declaration for NUMBER size

class questions{

public:

char number[100];//THe problem might lie here
void addQuestion();

};

void questions::addQuestion()
{
int i = 0;
const int NUMBER = 50;
cout << "Enter the question number: " << endl; //after this line is where it seg faults
cin.get(number,NUMBER, '\n');
cout<<number;
}

int main()
{
questions Q;//Object declaration for the questions class named Q
Q.addQuestion();//Calling the function addQuestion member function
return 0;
}

You might not variables for the class for question class .
Above i have shown how to declare the variable in the class.

follow as per above you might execute your code.

DeSKLUP #include <iostream> using namespace std; class questions{ public: char number[100]; void addQuestion(); void questions::addQuestion() int i = 0; const int NUMBER = 50; cout << "Enter the question number: " <endl; cin.get(number , NUMBER, '\n'); cout<<number;//Printed the line for the purpose that the code is executing correctly //Paste your remaning code and Carefully monitor the declartion in the class int main() questions ; Q.addQuestion(); return 0;

dsfsumanth@sumanth-Lenovo-ideapad-Y700-Touch-15ISK:-/Desktop$ g++ CPP.CPP sumanth@sumanth-Lenovo-ideapad-Y700-Touch-15ISK:-/Desktops./a.out Enter the question number: Code executed correctly Code executed correctlysumanth@sumanth-Lenovo ideapad-Y700-Touch-15ISK:-/Desktop