Question

Hello,
I am working on a C++ pick 5 lottery game that gives you the option to play over and over. I have everything working right except that every time the game runs it generates the same winning numbers. I know this is an srand or rand problem, (at least I think it is), but I can't figure out what my mistake is. I've tried moving srand out of the loop, but I'm still getting the same random numbers every time the program runs.
I would really appreciate any help I could get on this. Thank you

Here is a copy of my code:

#include <iostream>
#include <cstdlib>
#include <ctime>

using namespace std;
const int list_size =5; //declare variables
int seqSearch(const int list[],int listLength,int searchItem);

void generatePick5Numbers(int list[], int length);
int main()
{
int winningNumbers[list_size];
int playerPick[list_size];
int numbersMatched = 0;

srand(time(0));
generatePick5Numbers(winningNumbers, list_size);
   char ch;
do{
   cout << "Welcome to Pick 5 Lotto!" << endl;
   cout << "Enter 5 numbers between 1 - 9, inclusive." << endl;
   cout << "Include a space between each number: "<<endl;

   for (int i = 0; i < list_size; i++) //store random number in array
   cin >>playerPick[i];
   cout << endl;

   for (int i = 0; i < list_size;i++)
   if (winningNumbers[i] == playerPick[i])//compare players number, check to see if they are equal to random generated number
   {

     
   numbersMatched++;
   }

   cout << endl;

   if (numbersMatched == 5)
   cout << "YOU WIN!!!" << endl;
   else
   {
   cout << "You matched " << numbersMatched << " numbers in the correct position." << endl;
   cout << "The winning numbers are:"<< endl;
   for (int i = 0; i < list_size; i++)
   cout <<winningNumbers[i] << endl;

   cout << "Feeling Lucky? Try Pick 5 Lotto Again!" << endl;
   cout << endl;
   cout <<"Enter 'Y/y' to play again." << endl;
   cin>> ch;

   }
   }while(ch == 'y'|| ch=='Y');

return 0;
}

void generatePick5Numbers(int list[], int length)
{
int num;
int count;

//srand to generate random numbers

list[0] = static_cast<int> (rand()) % 9 + 1;
count = 1; //store random number 1-9 in an array

while (count < 5)
{
num = static_cast<int> (rand()) % 9+1;
if (seqSearch(list, count, num) == -1)
{
list[count] = num;
count++;
}
}
}

int seqSearch(const int list[], int listLength, int searchItem)
{
int loc;
bool found = false;

loc = 0;

while (loc < listLength && !found)
if (list[loc] == searchItem)
found = true;
else
loc++;

if (found)
return loc;
else
return -1;

}

Answer 1

#include <iostream>
#include <cstdlib>
#include <ctime>

using namespace std;
const int list_size =5; //declare variables
int seqSearch(const int list[],int listLength,int searchItem);

void generatePick5Numbers(int list[], int length);
int main()
{
int winningNumbers[list_size];
int playerPick[list_size];
int numbersMatched = 0;

srand(time(0));
char ch;
do{
generatePick5Numbers(winningNumbers, list_size);
cout << "Welcome to Pick 5 Lotto!" << endl;
cout << "Enter 5 numbers between 1 - 9, inclusive." << endl;
cout << "Include a space between each number: "<<endl;

for (int i = 0; i < list_size; i++) //store random number in array
cin >>playerPick[i];
cout << endl;

for (int i = 0; i < list_size;i++)
if (winningNumbers[i] == playerPick[i])//compare players number, check to see if they are equal to random generated number
{

numbersMatched++;
}

cout << endl;

if (numbersMatched == 5)
cout << "YOU WIN!!!" << endl;
else
{
cout << "You matched " << numbersMatched << " numbers in the correct position." << endl;
cout << "The winning numbers are:"<< endl;
for (int i = 0; i < list_size; i++)
cout <<winningNumbers[i] << endl;

cout << "Feeling Lucky? Try Pick 5 Lotto Again!" << endl;
cout << endl;
cout <<"Enter 'Y/y' to play again." << endl;
cin>> ch;

}
}while(ch == 'y'|| ch=='Y');

return 0;
}

void generatePick5Numbers(int list[], int length)
{
int num;
int count;

//srand to generate random numbers

list[0] = static_cast<int> (rand()) % 9 + 1;
count = 1; //store random number 1-9 in an array
srand(time(0));
while (count < 5)
{
num = (rand() % 9)+1;
if (seqSearch(list, count, num) == -1)
{
list[count] = num;
count++;
}
}
}

int seqSearch(const int list[], int listLength, int searchItem)
{
int loc;
bool found = false;

loc = 0;

while (loc < listLength && !found)
if (list[loc] == searchItem)
found = true;
else
loc++;

if (found)
return loc;
else
return -1;

}