Question

Need help with a C++ program. I have been getting the error "this function or variable may be unsafe" as well as one that says I must "return a value" any help we be greatly appreciated. I have been working on this project for about 2 hours.

#include <iostream>
#include <string>

using namespace std;
int average(int a[]) {
   // average function , declaring variable
   int i;
   char str[40];
   float avg = 0;
   // iterating in loop
   for (i = 0;i < 12;i++)
       avg += a[i];
   // average calculate and formatting of output
   avg = avg / 12;
   getline(str, "%.2f", avg);
   getline(str, "%f", &avg);
   // printing output
   cout << "The average score is " << str << endl;

}
int highest(int a[]) {
   // highest function
   int i, high = 0;
   for (i = 0;i < 12;i++) {
       // taking greatest Number from array
       if (a[i] > high)
           high = a[i];
   }
   // printing output
   cout << "The highest score is " << high << endl;

}
int low(int a[]) {
   // low calculate function
   int i, lowest = 101;
   for (i = 0;i < 12;i++) {
       // if lower than lowest
       if (a[i] < lowest)
           lowest = a[i];
   }
   // printing output
   cout << "The lowest score is " << lowest << endl;

}
int pass(int a[])
{
   // declaring variable
   int i, passed = 0;
   for (i = 0;i < 12;i++) {
       if (a[i] >= 60)
           passed += 1;
   }
   // printing output
   cout << "Number of students who passed: " << passed << endl;
}
int fail(int a[])
{
   // declaring variable
   int i, failed = 0;
   for (i = 0;i < 12;i++) {
       if (a[i] < 60)
           failed += 1;

   }
   // printing output
   cout << "Number of students who failed: " << failed << endl;
}
int graded(int a[])
{
   // declaring variable grades
   int i, A = 0, B = 0, C = 0, D = 0, F = 0;
   for (i = 0;i < 12;i++) {
       // depending upon marks increasing grade
       if (a[i] >= 90)
           A += 1;
       else if (a[i] >= 80 && a[i] <= 89)
           B += 1;
       else if (a[i] >= 70 && a[i] <= 79)
           C += 1;
       else if (a[i] >= 60 && a[i] <= 69)
           D += 1;
       else
           F += 1;
   }
   // printing output
   cout << "The number of exams represented by each letter grade is as follows:" << endl;
   cout << "A's:" << A << endl;
   cout << "B's:" << B << endl;
   cout << "C's:" << C << endl;
   cout << "D's:" << D << endl;
   cout << "F's:" << F << endl;
   return 0;
}
int main()
{
   // Declaring variables
   int a[12], i, j;
   string name;
   char choice;
   do {
       // Taking input as exam name
       cout << "Please Enter the name of the exam:?";
       getline(cin, name);
       // Taking marks as input
       for (i = 0;i < 12;i++) {
           cout << "Enter score " << i + 1 << ";?";
           cin >> a[i];
           // validating marks
           if (a[i] >= 0 and a[i] <= 100) {
               continue;
           }
           else {
               i--;
               cout << "Please Enter the correct marks between 0 and 100" << endl;
           }

       }
       // printing desired output
       cout << "The score of " << name << " are:" << endl;
       for (i = 0;i < 12;i++)
           // printing marks
           cout << a[i] << " ";
       cout << endl;
       // calling various funcctions
       average(a);
       highest(a);
       low(a);
       pass(a);
       fail(a);
       graded(a);
       // taking input for continuation
       cout << "Would you like to calculate the average for another exam? <Y or N> ";
       cin >> choice;
       // validating choice
   } while (choice == 'y' || choice == 'Y');
   return 0;
}

Answer 1

#include <iostream>
#include <string>

using namespace std;
int average(int a[]) {
// average function , declaring variable
int i;
char str[40];
float avg = 0;
// iterating in loop
for (i = 0;i < 12;i++)
avg += a[i];
// average calculate and formatting of output
avg = avg / 12;
//getline(str, "%.2f", avg);
//getline(str, "%f", &avg);
// printing output
cout << "The average score is " << avg << endl;
return avg;

}
int highest(int a[]) {
// highest function
int i, high = 0;
for (i = 0;i < 12;i++) {
// taking greatest Number from array
if (a[i] > high)
high = a[i];
}
// printing output
cout << "The highest score is " << high << endl;
return high;

}
int low(int a[]) {
// low calculate function
int i, lowest = 101;
for (i = 0;i < 12;i++) {
// if lower than lowest
if (a[i] < lowest)
lowest = a[i];
}
// printing output
cout << "The lowest score is " << lowest << endl;
return lowest;

}
int pass(int a[])
{
// declaring variable
int i, passed = 0;
for (i = 0;i < 12;i++) {
if (a[i] >= 60)
passed += 1;
}
// printing output
cout << "Number of students who passed: " << passed << endl;
}
int fail(int a[])
{
// declaring variable
int i, failed = 0;
for (i = 0;i < 12;i++) {
if (a[i] < 60)
failed += 1;

}
// printing output
cout << "Number of students who failed: " << failed << endl;
}
int graded(int a[])
{
// declaring variable grades
int i, A = 0, B = 0, C = 0, D = 0, F = 0;
for (i = 0;i < 12;i++) {
// depending upon marks increasing grade
if (a[i] >= 90)
A += 1;
else if (a[i] >= 80 && a[i] <= 89)
B += 1;
else if (a[i] >= 70 && a[i] <= 79)
C += 1;
else if (a[i] >= 60 && a[i] <= 69)
D += 1;
else
F += 1;
}
// printing output
cout << "The number of exams represented by each letter grade is as follows:" << endl;
cout << "A's:" << A << endl;
cout << "B's:" << B << endl;
cout << "C's:" << C << endl;
cout << "D's:" << D << endl;
cout << "F's:" << F << endl;
return 0;
}
int main()
{
// Declaring variables
int a[12], i, j;
string name;
char choice;
do {
// Taking input as exam name
cout << "Please Enter the name of the exam:?";
getline(cin, name);
// Taking marks as input
for (i = 0;i < 12;i++) {
cout << "Enter score " << i + 1 << ";?";
cin >> a[i];
// validating marks
if (a[i] >= 0 and a[i] <= 100) {
continue;
}
else {
i--;
cout << "Please Enter the correct marks between 0 and 100" << endl;
}

}
// printing desired output
cout << "The score of " << name << " are:" << endl;
for (i = 0;i < 12;i++)
// printing marks
cout << a[i] << " ";
cout << endl;
// calling various funcctions
average(a);
highest(a);
low(a);
pass(a);
fail(a);
graded(a);
// taking input for continuation
cout << "Would you like to calculate the average for another exam? <Y or N> ";
cin >> choice;
// validating choice
} while (choice == 'y' || choice == 'Y');
return 0;
}

Note : Please comment below if you have concerns. I am here to help you

If you like my answer please rate and help me it is very Imp for me