Question

1. The following global function takes as input parameters an array of bird objects as defined in Bird.h and the length of the array. It returns the bird with the largest wing span. There are multiple errors with the code. Please clearly identify them, including style issues.

Bird.h

class Bird

{ public:

Bird();

~Bird(); int WingSpan;

};

Main.cpp

const int MAXBIRDS 14;

int main()

{

Bird biggest, b[MAXBIRDS];

...some code assume is ok …

biggest = LargestWingSpan(b, MAXBIRDS);

return 0;

}

Bird& LargestWingSpan(Bird *birds, int &Length) {

int i; Bird bigBird(“name”);

bigBird = birds[i]; for (i = 1; i <= Length; i++) {

if (birds[i].WingSpan > bigBird.WingSpan) bigBird = birds[i];

} return bigBird;

}

Answer 1

1. Indentation need to be corrected in both the files. The indented code is given below

2. In Main.cpp, the Bird.h header file need to be included using #include
3. There is no constructor defined in the Bird class. A constructor with int argument should be defined to initialize wingSpan. The corrected code shows the constructor)
4. The for loop should start at index 0 and go to less than length like this
   for (i = 0; i < Length; i++) {
       ....
   }
  
5. The return type should be modified to Bird and remove the & symbol since we can return a reference to local variable. The correct function signature should be
Bird LargestWingSpan(Bird *birds, int &Length) {
   ....
}

6. The constant should be assigned using = symbol like this
const int MAXBIRDS=14;

7. The function prototype for LargestWingSpan() should be added before main() function. Also the signature should be modified to using const int& instead of int &.

Bird LargestWingSpan(Bird *birds, const int &Length);

8. The constructors and destructors of Bird class need to implemented in a file named Bird.cpp

============================================
All correct files are given below

Bird.h
----

class Bird
{
   public:
       Bird();
       Bird(int w);
       ~Bird();
      
       int WingSpan;

};

Bird.cpp
-----

#include "Bird.h"
Bird::Bird(){ WingSpan = 0;}
Bird::Bird(int w) {WingSpan = w; }
Bird::~Bird(){}

Main.cpp
-----
#include "Bird.h"
const int MAXBIRDS=14;
Bird LargestWingSpan(Bird *birds, const int &Length);

int main()

{

   Bird biggest, b[MAXBIRDS];

   //...some code assume is ok …
   biggest = LargestWingSpan(b, MAXBIRDS);

   return 0;
}

Bird LargestWingSpan(Bird *birds, const int &Length){
   int i;
   Bird bigBird(0);
   bigBird = birds[i];
   for (i = 0; i < Length; i++) {
       if (birds[i].WingSpan > bigBird.WingSpan)
           bigBird = birds[i];
   }
   return bigBird;
}