Question

////****what am i doing wrong? im trying to have this program with constructors convert inches to feet too I don't know what im doing wrong. (the program is suppose to take to sets of numbers feet and inches and compare them to see if they are equal , greater, less than, or not equal using operator overload

#include <stdio.h>
#include <string.h>
#include <iostream>
#include <iomanip>
#include <cmath>

using namespace std;

//class declaration
class FeetInches {
private:
   int feet;
   int   inches;
   void simplify();

public:
   //constructor
   FeetInches(int f = 0, int i = 0){
       feet = f;
       inches = i;
       simplify();
   }

   //mutator
   void setFeet(int f) {
       feet = f;
   }
   void setInches(int i) {
       inches = i;
   }

   //accessors
   int getFeet() {
       return feet;
   }
   int getInches() {
       return inches;
   }

   bool operator < (FeetInches const &obj) {
       if (feet == obj.feet) {
           return inches < obj.inches;
       }
       return feet < obj.feet;
   }

   bool operator <= (FeetInches const &obj) {
       if (feet == obj.feet) {
           return inches <= obj.inches;
       }
       return feet <= obj.feet;
   }

   bool operator > (FeetInches const &obj) {
       if (feet == obj.feet) {
           return inches > obj.inches;
       }
       return feet > obj.feet;
   }

   bool operator >= (FeetInches const &obj) {
       if (feet == obj.feet) {
           return inches >= obj.inches;
       }
       return feet >= obj.feet;
   }

   bool operator == (FeetInches const &obj) {
       return feet == obj.feet&& inches == obj.inches;
   }

   bool operator != (FeetInches const &obj) {
       return feet != obj.feet || inches != obj.inches;
   }

   void simplify(){
       if (inches >= 12)
       {
           feet += (inches / 12);
           inches = inches % 12;
       }
       else if (inches < 0)
       {
           feet -= ((abs(inches) / 12) + 1);
           inches = 12 - (abs(inches) % 12);
       }
   }
};

int main() {
   int feet, inches;

   FeetInches first, second;
   cout << "Enter a distance in feet and inches: ";
   cin >> feet >> inches;
   first.setFeet(feet);
   first.setInches(inches);
   cout << "Enter another distance in feet and inches: ";
   cin >> feet >> inches;
   second.setFeet(feet);
   second.setInches(inches);

   //if else statements that will call the operator overload
   if (first < second && first != second){
       cout << "First is less than second " << endl;
   }
   else if (first == second) {
       cout << "They are equal " << endl;
   }
   else {
       cout << "First is greater than second " << endl;
   }
   return 0;
}

Answer 1

The Errors in your code were:

declaration and definition of void simplify() was within the same class.

Either remove the declaration or move the definition outside of class.

I removed the declaration void simplify() on the top.

There was also logical error because the mutator setInches() should also simplify() inches.

I have modified the code a little and marked the changes as Changed (in comments)

**********************modified_code.cpp****************************

#include <stdio.h>
#include <string.h>
#include <iostream>
#include <iomanip>
#include <cmath>

using namespace std;

//class declaration
class FeetInches {
private:
int feet;
int inches;
//Changed:Removed declaration

public:
//constructor
FeetInches(int f = 0, int i = 0){
feet = f;
inches = i;
simplify();
}

//mutator
void setFeet(int f) {
feet = f;
}
void setInches(int i) {
inches = i;
//Changed: used simplify also within this function
simplify();
}

//accessors
int getFeet() {
return feet;
}
int getInches() {
return inches;
}

bool operator < (FeetInches const &obj) {
if (feet == obj.feet) {
return inches < obj.inches;
}
return feet < obj.feet;
}

bool operator <= (FeetInches const &obj) {
if (feet == obj.feet) {
return inches <= obj.inches;
}
return feet <= obj.feet;
}

bool operator > (FeetInches const &obj) {
if (feet == obj.feet) {
return inches > obj.inches;
}
return feet > obj.feet;
}

bool operator >= (FeetInches const &obj) {
if (feet == obj.feet) {
return inches >= obj.inches;
}
return feet >= obj.feet;
}

bool operator == (FeetInches const &obj) {
return feet == obj.feet&& inches == obj.inches;
}

bool operator != (FeetInches const &obj) {
return feet != obj.feet || inches != obj.inches;
}
//Changed:Made definition private
private:
void simplify(){
if (inches >= 12)
{
feet += (inches / 12);
inches = inches % 12;
}
else if (inches < 0)
{
feet -= ((abs(inches) / 12) + 1);
inches = 12 - (abs(inches) % 12);
}
}
};

int main() {
int feet, inches;

FeetInches first, second;
cout << "Enter a distance in feet and inches: ";
cin >> feet >> inches;
first.setFeet(feet);
first.setInches(inches);
cout << "Enter another distance in feet and inches: ";
cin >> feet >> inches;
second.setFeet(feet);
second.setInches(inches);

//if else statements that will call the operator overload
if (first < second && first != second){
cout << "First is less than second " << endl;
}
else if (first == second) {
cout << "They are equal " << endl;
}
else {
cout << "First is greater than second " << endl;
}
return 0;
}